nimble/host: add Client Supported Features bit masks - #2270
Open
piotrnarajowski wants to merge 1 commit into
Open
nimble/host: add Client Supported Features bit masks#2270piotrnarajowski wants to merge 1 commit into
piotrnarajowski wants to merge 1 commit into
Conversation
Contributor
Author
|
@KKopyscinski FYI |
piotrnarajowski
force-pushed
the
cl_sup_feat_masks
branch
2 times, most recently
from
August 11, 2026 13:30
9a8c681 to
93e0252
Compare
Define and apply possible bit masks for GATT Client Supported Features characteristic value to ged rid of magic numbers.
piotrnarajowski
force-pushed
the
cl_sup_feat_masks
branch
from
August 11, 2026 13:39
93e0252 to
34a94e9
Compare
sjanc
reviewed
Sep 11, 2026
| #include "host/ble_uuid.h" | ||
| #include "host/ble_gap.h" | ||
| #include "ble_hs_priv.h" | ||
| #include "../services/gatt/include/services/gatt/ble_svc_gatt.h" |
Contributor
There was a problem hiding this comment.
I don't like it, it add hidden service dependency to gatt code
I'm not yet sure on how to handle this though, maybe make those in public host header, or maybe add explicit dependency on that service (and GAP?)
need to think about this a bit more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define possible bit masks for GATT Client Supported Features characteristic value to get rid of magic numbers.