feat: Add Mille Solver - #5954
Open
goblirsc wants to merge 13 commits into
Open
feat: Add Mille Solver #5954goblirsc wants to merge 13 commits into
goblirsc wants to merge 13 commits into
Conversation
Contributor
Public API surface diff+22 added, 0 breaking. ➕ Added public APINew types / aliases / enums / variables / concepts (4)
New call signatures (incl. defaulted-arg overloads) (3)
New public data members (15)
|
goblirsc
force-pushed
the
MG_MilleSolver
branch
from
August 26, 2026 16:42
40c5b6d to
2bea6dd
Compare
github-actions
Bot
added
the
Infrastructure
Contributor
Author
|
Two questions to the experts triggered by unit test failures (e.g. lcg_109_alma9_gcc15 (pull_request))
|
goblirsc
force-pushed
the
MG_MilleSolver
branch
from
September 8, 2026 11:23
9dfa940 to
92d51ec
Compare
github-actions
Bot
added
Component - Core
goblirsc
force-pushed
the
MG_MilleSolver
branch
from
September 21, 2026 08:16
0f28665 to
fd24cb2
Compare
github-actions
Bot
removed
Component - Core
github-actions
Bot
removed
Component - Examples
Contributor
goblirsc
marked this pull request as ready for review
September 22, 2026 08:25
andiwand
reviewed
Sep 22, 2026
Comment on lines
+22
to
+31
| #if BOOST_VERSION >= 108800 | ||
|
|
||
| #include <boost/process/environment.hpp> | ||
| #include <boost/process/process.hpp> | ||
| #include <boost/process/start_dir.hpp> | ||
| #include <boost/process/stdio.hpp> | ||
|
|
||
| #else | ||
| #include <boost/process.hpp> | ||
| #endif |
Contributor
There was a problem hiding this comment.
do we support both versions?
Contributor
Author
There was a problem hiding this comment.
We currently support Boost starting from fairly early (pre 1.80), so yes, unfortunately our supported boost range covers both API versions (the switch happened in 1.88).
With the two-header strategy you suggested, it is however fairly easy to get rid of the "old" one once we reach the point of dropping pre-1.88 versions.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a MilleSolver to handle running the MillePede alignment step and collect the results.
Adds a
MilleSolverwhich wraps the call topede. It allows to redirect the output and returns astructwith the fit status and the location of the output files.Currently, it expects the user to have already configured the steering file for the fit - this will be handled by one of the next PRs in the ongoing stack, by a separate tool.
The child process call required for this wrapping is currently done via
Boost::process. For the longer-term future, a refactor ofpedeis foreseen to allow running the alignment fit via an API call to a library, rather than having to invoke an external program. Once that becomes available, this wrapper will be replaced accordingly.The PR also adds python bindings for the solver and its configuration, as well as a unit test.