feature branch validation of names

[nissessenap]

Today it's possible to hang a entire gitops promotion due to some developer writing a bad branch that only includes app-frontend-
Since gitops promotion knows the name when creating the feature it should be able to check if it ends with -. If so we should do an exit 1.

And write a log to the user that it's unable to apply due to naming.

[bittrance]

I take it you mean we should validate the input to new? Since we read the PR desc for input when doing promote, we should prolly validate input here

gitops-promotion/pkg/command/promote.go

Line 54 in f46a66d

manifestPath := fmt.Sprintf("%s/%s/%s", repo.GetRootDir(), state.Group, state.Env)

.