feat: add missing settings and fix enum in pnpm-workspace schema - #6286
Merged
Conversation
…ace schema Add five settings documented on https://pnpm.io/settings that the schema was missing, causing "Property X is not allowed" errors in editors: - virtualStoreType (project | global, added in pnpm v11.23.0) - frozenStore (boolean, added in pnpm v11.7.0) - globalShims (boolean or per-package policy map, added in pnpm v12.0.0-rc.2) - ci (boolean, added in pnpm v10.12.1) - useRunningStoreServer (boolean, deprecated but still parsed) Also fix the hoistingLimits enum: "node" -> "none", matching the documented values (none | workspaces | dependencies). Extend the pnpm-workspace test fixture to cover all new fields and the corrected enum value.
Contributor
|
Thanks for the PR! This section of the codebase is owned by @danielbayley and @btea - if they write a comment saying "LGTM" then it will be merged. |
Contributor
|
@btea You want to double check this before |
Contributor
|
@danielbayley Thanks for reminding me; it seems there's no problem. |
Contributor
|
LGTM |
Contributor
|
Merging because @btea is a code-owner of all the changes - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I discovered that
virtualStoreTypewas missing from the schema, and on comparing against the documentation, I found a few other gaps. See below for what I added/fixed:virtualStoreType,frozenStore,globalShims,ci, anduseRunningStoreServer(deprecated, noted in description), typed per the docshoistingLimitsenum typo:"node"→"none"(docs:none | workspaces | dependencies)Verified with
node ./cli.js check --schema-name=pnpm-workspace.json.Please let me know if you need anything else. Thanks in advance for your review!