From 139b0783ae7ccb6a13150c5c56b26551b2b2caea Mon Sep 17 00:00:00 2001 From: u9g Date: Sun, 6 Sep 2026 21:02:56 -0400 Subject: [PATCH] test: give the declare_commands tree the packet's rootIndex The tree the test emits has no rootIndex, so the client reads nodes[undefined], rejects the tree and ends the connection, and the test's only assertion never runs. It has failed since it was added. Nothing reported it because CI runs mochaTest with a -g filter on the Minecraft version and no name in this file carries one. --- test/declareCommandsTest.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/declareCommandsTest.js b/test/declareCommandsTest.js index 893bb26e..74e59f37 100644 --- a/test/declareCommandsTest.js +++ b/test/declareCommandsTest.js @@ -41,6 +41,7 @@ describe('declare_commands handling', () => { client.signMessage = () => Buffer.from([1]) client.emit('declare_commands', { + rootIndex: 0, nodes: [ { children: [1] }, { children: [2], extraNodeData: { name: 'msg' } },