PlayerProfile cache completions perform web requests

[Krakenied]

Expected behavior

Observed/Actual behavior

Steps/models to reproduce

Just use the method

Plugin and Datapack List

null

Paper version

ver
[04:24:47 INFO]: This server is running Paper version 26.2-120-main@1797fbc (2026-08-28T19:56:08Z) (Implementing API version 26.2.build.120-stable)
You are running the latest version

Other

Possibly:

diff --git a/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java b/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java
--- a/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java    (revision 26b94ad553e32a4fb8f7790e3eef3a6c32b77953)
+++ b/src/main/java/com/destroystokyo/paper/profile/CraftPlayerProfile.java    (date 1787969857353)
@@ -236,7 +236,7 @@
             if (onlineMode) {
                 profile = server.services().paper().filledProfileCache().getIfCached(name);
                 if (profile == null && lookupUUID) {
-                    NameAndId nameAndId = server.services().nameToIdCache().get(name).orElse(null);
+                    NameAndId nameAndId = server.services().nameToIdCache().getIfCached(name);
                     if (nameAndId != null) {
                         profile = nameAndId.toUncompletedGameProfile();
                     }

However I think that there's need to actually rethink the entire method body. I'm not even sure why there's textures check:

        if ((profile.name().isEmpty() || !hasTextures()) && this.getId() != null) {
            GameProfile profile = server.services().paper().filledProfileCache().getIfCached(this.profile.id());
            if (profile == null) {

Also, additional overload would be nice to have if the textures check is actually meant to be there, for example:

public boolean completeFromCache(boolean lookupUUID, boolean textures, boolean onlineMode) {

[Krakenied]

There's also a possibility that it's intentional, with lookupUUID being a flag to prevent network calls, but there are no docs mentioning that the lookup involves network calls

[electronicboy]

Looking at the logic this seems entirely intentional, lookupUUID controls if the thing should do a lookup of the UUID if it's not available

"textures" is what notes a profile as being 'complete'

[Krakenied]

"textures" is what notes a profile as being 'complete'

The docs are hella confusing then

There's need for additional info that Does not account for textures. applies to the return value.

The docs for completeness also seem quite confusing, but it's just the description being copied from extended interface.

These are not enough specific either. There is no information that the return value depends on having the textures property and specific parameter values. There's also no information about how it will fail - will it just gracefully return false or throw an exception?

Looking at the logic this seems entirely intentional

Probably, however I Istill think that the docs need improvement. Method name is completeFromCache, and description says that it will try only from cache and make no network calls. That's not how method behaves in this case. Probably adding a note that lookupUUID: true causes a non-cache-only lookup would be sufficient.

It also wouldn't hurt to have another overload, but that's a thing for a feature request.

boolean completeFromCache(boolean lookupUUID, boolean textures, boolean onlineMode);

[electronicboy]

This stuff was written many moons ago with somewhat of an understanding that if you're touching it you understand what's going on under the hood; They are probably due a cleanup, I think "textures" being the complete marker might only apply in some areas, would need to validate the code there

[Krakenied]

Ah, forgot to post another image - textures are used in complete() and its overloads