fix(smoke-web): don't report post-execute canonicalization lag as execution failure - #431
Open
haseebrabbani wants to merge 1 commit into
Open
fix(smoke-web): don't report post-execute canonicalization lag as execution failure#431haseebrabbani wants to merge 1 commit into
haseebrabbani wants to merge 1 commit into
Conversation
…cution failure GUARDIAN keeps reporting a just-executed proposal's delta until it observes the on-chain commitment. In that window syncProposals re-validates the delta against the local account state the execution already advanced and throws, so the refresh inside the executeProposal command failed the whole command even though the transaction had submitted. Retry the refresh through the canonicalization window, and surface an executed-but-pending snapshot instead of throwing if it still has not converged; any error outside the two known transient signatures still fails the command.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After
executeProposalsubmits successfully, GUARDIAN keeps reporting the just-executed proposal's delta until canonicalization observes the on-chain commitment. During that window,syncProposalsre-validates the delta against the local account state the execution already advanced and throwsInvalid proposal: metadata does not match tx_summary. The smoke-webexecuteProposalcommand runsrefreshMultisigStateright after submit, so this transient surfaced as a failure of the whole command even though the transaction had landed — every create/sign/execute canary against a deployed GUARDIAN reported a spurious execute failure.The Rust client never sees this because
list_proposalspre-filters proposals withnonce <= account.nonce()before binding verification; the TS client intentionally has no such filter (see the nonce-convention rationale in #405), so the tolerance belongs in the app.Fix
refreshMultisigStatethrough the canonicalization window (5 attempts, 2s apart) when the failure matches one of the two known transient signatures:metadata does not match tx_summaryor the nonce-overwrite (is not greater than local nonce).lastErrordescribing the state instead of throwing — the command reports what actually happened (the transaction submitted).