Generate password on first boot

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>

Author: mgaffigan

server/conf/mirth.properties

@@ -54,6 +54,10 @@ server.api.accesscontrolallowheaders = Content-Type
 server.api.accesscontrolexposeheaders = 
 server.api.accesscontrolmaxage = 
 
+# Password for the admin user, only applied when the database is first created.
+# If blank, a random password is generated and written to the log once on first startup.
+server.initialadminpassword = 
+
 # Determines whether or not channels are deployed on server startup.
 server.startupdeploy = true
 

server/dbconf/derby/derby-database.sql

@@ -105,8 +105,6 @@ CREATE TABLE DEBUGGER_USAGE
 
 INSERT INTO PERSON (USERNAME, LOGGED_IN) VALUES('admin', 0);
 
-INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD) VALUES(1, 'b8cA3mDkavInMc2JBYa6/C3EGxDp7ppqh7FsoXx0x8+3LWK3Ed3ELg==');
-
 INSERT INTO SCHEMA_INFO (VERSION) VALUES ('4.6.0');
 
 INSERT INTO CONFIGURATION (CATEGORY, NAME, VALUE) VALUES ('core', 'stats.enabled', '1');

server/dbconf/mysql/mysql-database.sql

@@ -111,8 +111,6 @@ CREATE TABLE DEBUGGER_USAGE
 
 INSERT INTO PERSON (USERNAME, LOGGED_IN) VALUES('admin', FALSE);
 
-INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD) VALUES(1, 'b8cA3mDkavInMc2JBYa6/C3EGxDp7ppqh7FsoXx0x8+3LWK3Ed3ELg==');
-
 INSERT INTO SCHEMA_INFO (VERSION) VALUES ('4.6.0');
 
 INSERT INTO CONFIGURATION (CATEGORY, NAME, VALUE) VALUES ('core', 'stats.enabled', '1');

server/dbconf/oracle/oracle-database.sql

@@ -108,8 +108,6 @@ CREATE TABLE DEBUGGER_USAGE
 
 INSERT INTO PERSON (ID, USERNAME, LOGGED_IN, USERCONSENT) VALUES (PERSON_SEQUENCE.NEXTVAL, 'admin', '0', '0');
 
-INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD) VALUES(PERSON_SEQUENCE.CURRVAL, 'b8cA3mDkavInMc2JBYa6/C3EGxDp7ppqh7FsoXx0x8+3LWK3Ed3ELg==');
-
 INSERT INTO SCHEMA_INFO (VERSION) VALUES ('4.6.0');
 
 INSERT INTO CONFIGURATION (CATEGORY, NAME, VALUE) VALUES ('core', 'stats.enabled', '1');

server/dbconf/postgres/postgres-database.sql

@@ -107,8 +107,6 @@ CREATE TABLE DEBUGGER_USAGE
 
 INSERT INTO PERSON (USERNAME, LOGGED_IN) VALUES('admin', FALSE);
 
-INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD) VALUES(1, 'b8cA3mDkavInMc2JBYa6/C3EGxDp7ppqh7FsoXx0x8+3LWK3Ed3ELg==');
-
 INSERT INTO SCHEMA_INFO (VERSION) VALUES ('4.6.0');
 
 INSERT INTO CONFIGURATION (CATEGORY, NAME, VALUE) VALUES ('core', 'stats.enabled', '1');

server/dbconf/sqlserver/sqlserver-database.sql

@@ -114,8 +114,6 @@ CREATE TABLE DEBUGGER_USAGE
 
 INSERT INTO PERSON (USERNAME, LOGGED_IN, USERCONSENT) VALUES('admin', 0, 0);
 
-INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD) VALUES(1, 'b8cA3mDkavInMc2JBYa6/C3EGxDp7ppqh7FsoXx0x8+3LWK3Ed3ELg==');
-
 INSERT INTO SCHEMA_INFO (VERSION) VALUES ('4.6.0');
 
 INSERT INTO CONFIGURATION (CATEGORY, NAME, VALUE) VALUES ('core', 'stats.enabled', '1');

server/src/main/java/com/mirth/connect/client/core/api/servlets/UserServletInterface.java

@@ -63,7 +63,7 @@ public interface UserServletInterface extends BaseServletInterface {
     @MirthOperation(name = "login", display = "Login")
     public LoginStatus login(// @formatter:off
             @Param("username") @Parameter(description = "The username to login with.", required = true, schema = @Schema(defaultValue = "admin")) @FormParam("username") String username,
-            @Param(value = "password", excludeFromAudit = true) @Parameter(description = "The password to login with.", required = true, schema = @Schema(defaultValue = "admin")) @FormParam("password") String password) throws ClientException;
+            @Param(value = "password", excludeFromAudit = true) @Parameter(description = "The password to login with.", required = true) @FormParam("password") String password) throws ClientException;
     // @formatter:on
 
     @POST

server/src/main/java/com/mirth/connect/server/migration/ServerMigrator.java

@@ -9,6 +9,7 @@
 
 package com.mirth.connect.server.migration;
 
+import java.security.SecureRandom;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
@@ -30,6 +31,7 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
+import com.mirth.connect.client.core.PropertiesConfigurationUtil;
 import com.mirth.connect.client.core.Version;
 import com.mirth.connect.model.Channel;
 import com.mirth.connect.model.ExportClearable;
@@ -38,9 +40,16 @@
 import com.mirth.connect.model.codetemplates.CodeTemplateLibrary;
 import com.mirth.connect.model.converters.ObjectXMLSerializer;
 import com.mirth.connect.model.util.MigrationException;
+import com.mirth.connect.server.Mirth;
+import com.mirth.connect.server.controllers.ConfigurationController;
+import com.mirth.connect.server.controllers.ControllerFactory;
 import com.mirth.connect.server.util.DatabaseUtil;
 
 public class ServerMigrator extends Migrator {
+    private static final String INITIAL_ADMIN_USERNAME = "admin";
+    private static final String INITIAL_ADMIN_PASSWORD_PROPERTY = "server.initialadminpassword";
+    private static final int GENERATED_PASSWORD_LENGTH = 20;
+
     private Logger logger = LogManager.getLogger(getClass());
 
     public ServerMigrator() {
@@ -250,25 +259,71 @@ private void initDatabase(Connection connection) throws MigrationException {
         if (!DatabaseUtil.tableExists(connection, "CONFIGURATION")) {
             executeScript("/" + getDatabaseType() + "/" + getDatabaseType() + "-database.sql");
 
-            /*
-             * We must update the password date for the initial user. Previously we let the database
-             * set this via CURRENT_TIMESTAMP, however this could create problems if the database is
-             * running on a separate machine in a different timezone. (MIRTH-2902)
-             */
-            PreparedStatement statement = null;
+            initializeAdminPassword();
 
-            try {
-                statement = getConnection().prepareStatement("UPDATE PERSON_PASSWORD SET PASSWORD_DATE = ?");
-                statement.setTimestamp(1, new Timestamp(System.currentTimeMillis()));
-                statement.executeUpdate();
-            } catch (SQLException e) {
-                throw new MigrationException(e);
-            } finally {
-                DbUtils.closeQuietly(statement);
+            updateVersion(Version.getLatest());
+        }
+    }
+
+    /**
+     * Sets the password for the initial administrator account. The password is taken from the
+     * server.initialadminpassword property if it is set, otherwise a random password is generated
+     * and logged once so that it can be used to log in for the first time.
+     * 
+     * The password date is set here rather than letting the database default it via
+     * CURRENT_TIMESTAMP, since that could create problems if the database is running on a separate
+     * machine in a different timezone. (MIRTH-2902)
+     */
+    private void initializeAdminPassword() throws MigrationException {
+        ConfigurationController configurationController = ControllerFactory.getFactory().createConfigurationController();
+        PropertiesConfiguration mirthProperties = PropertiesConfigurationUtil.create();
+        configurationController.updatePropertiesConfiguration(mirthProperties);
+        // Log through the central Mirth.class logger to hit log4j filter configs
+        Logger startupLogger = LogManager.getLogger(Mirth.class);
+
+        String password = mirthProperties.getString(INITIAL_ADMIN_PASSWORD_PROPERTY);
+        if (StringUtils.isBlank(password)) {
+            password = generatePassword();
+            startupLogger.warn(
+                "Generated an initial password for the \"{}\" user: {}\n"
+                + "This password is not logged again, so store it somewhere safe "
+                + "and change it after logging in. Set {} in mirth.properties "
+                + "before the first startup to choose the password instead.", 
+                INITIAL_ADMIN_USERNAME, password, INITIAL_ADMIN_PASSWORD_PROPERTY);
+        }
+
+        PreparedStatement statement = null;
+        try {
+            String digestedPassword = configurationController.getDigester().digest(password);
+
+            statement = getConnection().prepareStatement(
+                "INSERT INTO PERSON_PASSWORD (PERSON_ID, PASSWORD, PASSWORD_DATE) "
+                + "SELECT ID, ?, ? FROM PERSON WHERE USERNAME = ?");
+            statement.setString(1, digestedPassword);
+            statement.setTimestamp(2, new Timestamp(System.currentTimeMillis()));
+            statement.setString(3, INITIAL_ADMIN_USERNAME);
+
+            if (statement.executeUpdate() != 1) {
+                throw new MigrationException("Could not set the initial password for the \"" + INITIAL_ADMIN_USERNAME + "\" user.");
             }
+        } catch (SQLException e) {
+            throw new MigrationException(e);
+        } finally {
+            DbUtils.closeQuietly(statement);
+        }
+    }
 
-            updateVersion(Version.getLatest());
+    private String generatePassword() {
+        String characters = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
+        SecureRandom random = new SecureRandom();
+        StringBuilder builder = new StringBuilder();
+        // Ensure the password contains at least one lowercase letter, 
+        // one uppercase letter, one digit, and one special character
+        builder.append("Aa1!");
+        for (int i = 0; i < GENERATED_PASSWORD_LENGTH; i++) {
+            builder.append(characters.charAt(random.nextInt(characters.length())));
         }
+        return builder.toString();
     }
 
     /**