ci: add llakala as codeowner of performance-critical files - #535031
Merged
infinisil merged 2 commits intoJun 24, 2026
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
llakala
force-pushed
the
protect-meta-problems-from-regressions
branch
from
June 24, 2026 18:10
ce48bd8 to
03dfff6
Compare
llakala
changed the title
llakala
changed the title
jopejoe1
approved these changes
Jun 24, 2026
jopejoe1
left a comment
jopejoe1
left a comment
Member
There was a problem hiding this comment.
Thanks for working on improving performance in nixpkgs ^^
nixpkgs-ci
Bot
added
the
12.approvals: 1
infinisil
approved these changes
Jun 24, 2026
infinisil
left a comment
infinisil
left a comment
Member
There was a problem hiding this comment.
Very appreciated, and thanks for all the improvements!
This comment was marked as resolved.
This comment was marked as resolved.
mdaniels5757
removed
8.has: failed backport
backport release-26.05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing lots of nixpkgs performance work recently, and have been seeing seemingly-trivial PRs that result in very large performance regressions. I've been attempting to protect it by searching recent PRs manually. Adding myself to ensure I get pinged on these things.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.