Skip to content

Remove unnecessary "NonLocalTransport" wrappers and C_P argument #380

Description

@gustavo-marques

The subroutines KPP_NonLocalTransport_temp and KPP_NonLocalTransport_saln appear to be unnecessary wrappers for KPP_NonLocalTransport. Three years ago, @mnlevy1981 did a major refactor of KPP_NonLocalTransport (commit link here) and moved the diagnostic that required C_P elsewhere. As a result, passing C_P to the call is no longer needed and may cause confusion, and the wrapper subroutines serve no additional purpose.

Proposed changes:

  • Remove KPP_NonLocalTransport_temp and KPP_NonLocalTransport_saln.

  • Remove C_P from the call to KPP_NonLocalTransport.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions