Fix "Cannot read property 'match' of undefined" - #232
Merged
Conversation
This reverts commit 49dabe2.
Member
|
what's up with the tests? looks like something from ttypescript, maybe pull in the on that note, this seems to indicate that our types are wrong if that function is ever receiving |
Member
Author
|
Tests have been broken for a while because of node version. Seems like GitHub Actions has deprecated Node v12, so our actions (tests, lint) now run in v16 and everything breaks. Running locally with v12 does get the codebase to compile though ;) I have been trying to create a Dockerfile and update all our dependencies but haven't finished yet |
Member
Author
|
Screw it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.