Repository navigation
memories: document the Mechanism: discharge added by #4410 - #4411
Merged
Merged
Conversation
The claude-code-hooks.md entry on no-mistake-without-a-hook.py still named NOT_HOOKABLE as the only escape besides HOOK_WORK, and said a mechanism built elsewhere matches nothing. #4410 added MECHANISM_CITED, so that sentence no longer describes the hook. Raised as a non-blocking note in #4410's review. Refs #2389 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vwcai8NPoZC3GjwGwhcKHa
Collaborator
Author
|
/review Generated by Claude Code |
Contributor
Contributor
|
Claude finished review — View run Review: PR #4411 — "memories: document the Mechanism: discharge added by #4410"Scope: A single, minimal documentation fix to What I checked
I found no bugs, no CLAUDE.md violations, and no hallucinated content. This is a correct, well-scoped, self-contained doc fix with no blocking issues. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "e38f90b81be0fc1523cb9a048845d347f9c63576",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "memories/claude-code-hooks.md's new MECHANISM_CITED paragraph was checked line-by-line against the regex in hooks/no-mistake-without-a-hook.py and matches exactly, with no unsupported claims.",
"holistic_assessment": "Scope is a single documentation correction closing a gap from PR 4410's review; references to ai-config#4410 and ai-config#2389 resolve correctly and no other file needed the same update."
}Reviewed commit: e38f90b |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
memories/claude-code-hooks.mdsaidno-mistake-without-a-hook.pyhas two escapes,HOOK_WORKandNOT_HOOKABLE, and that a mechanism already built elsewhere "matches none of them". #4410 (merged as 1cc4c27) added a third,MECHANISM_CITED, so that sentence no longer describes the hook. #4410's review raised this as a non-blocking note.After: the entry describes the
Mechanism: <GitHub issue or PR URL>line form, says which shapes do not discharge it (word mid-sentence, URL on another line, non-GitHub URL), and adds a Do bullet for it.How: one hand edit, checked against the regex and test cases in
hooks/no-mistake-without-a-hook.pyandhooks/test-no-mistake-without-a-hook.pyon main. The file is 1194 lines, under the 1250 cap.Refs #2389
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vwcai8NPoZC3GjwGwhcKHa
Generated by Claude Code