Skip to content

Support Robot Framework Secret values for database passwords #259

Description

@GerwinLaagland

Description

Robot Framework 7.4 introduced the Secret type. It allows sensitive values such as passwords to be passed to keywords without exposing them in Robot Framework logs.

I would like to use a secret variable as the db_password argument of Connect To Database:

*** Variables ***
${DB_PASSWORD: Secret}    %{DB_PASSWORD}

*** Test Cases ***
Connect using a secret password
    Connect To Database
    ...    db_module=psycopg
    ...    db_name=example
    ...    db_user=robot
    ...    db_password=${DB_PASSWORD}
    ...    db_host=localhost

The current db_password argument accepts an optional string. Robot Framework deliberately rejects automatic conversion of a Secret object to a string, so the value needs to be accepted and accessed inside DatabaseLibrary before it is passed to the database driver. The error message currently:

ValueError: Argument 'db_password' got value '<secret>' (Secret) that cannot be converted to string or None.

Expected behaviour

Connect To Database should accept both regular strings and Robot Framework Secret objects as db_password.

When a Secret is provided, DatabaseLibrary should:

  • keep it protected while processing and logging connection parameters;
  • access its encapsulated value internally when required by the database driver;
  • avoid including the unwrapped value in log messages or library-generated diagnostics.

Existing string passwords and configuration-file passwords should continue to work unchanged.

It may also be worth checking whether password values passed through custom connection parameters need the same handling.

Compatibility consideration

DatabaseLibrary currently supports Python 3.8.1 and Robot Framework 5.0.1 or newer, while Secret was introduced in Robot Framework 7.4. The implementation therefore needs to preserve compatibility with supported versions or document any resulting change to the minimum Robot Framework version.

Acceptance criteria

  • Connect To Database accepts a Secret object as db_password.
  • The encapsulated value is passed to the database driver.
  • Existing string and None values continue to work.
  • Neither DatabaseLibrary logs nor library-generated diagnostics expose the unwrapped value.
  • Automated tests cover string and Secret password values.
  • The keyword documentation includes a short secret-variable example.

References

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions