Repository navigation
Improve precompilation - #359
Merged
Merged
Conversation
JamesWrigley
force-pushed
the
precompile
branch
from
December 12, 2025 15:57
124a83f to
3883d38
Compare
Member
Author
|
I fixed some of the formatting issues, but I felt the other suggestions make the code less readable 🤷 |
JamesWrigley
force-pushed
the
precompile
branch
from
December 12, 2025 15:59
3883d38 to
e08666e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 86.77% 87.07% +0.30%
==========================================
Files 11 12 +1
Lines 514 534 +20
==========================================
+ Hits 446 465 +19
- Misses 68 69 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
reviewed
Dec 27, 2025
In particular to `find_stale_deps()`, which took about 600ms to compile.
JamesWrigley
force-pushed
the
precompile
branch
from
February 24, 2026 17:36
b06a707 to
417a0fa
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fingolfin
reviewed
Feb 25, 2026
Comment on lines
+87
to
+88
| pkgname = get(TOML.parsefile(project), "name", "")::String | ||
| if isempty(pkgname) |
Member
Author
There was a problem hiding this comment.
That's to make it type-stable. I could also have changed the type annotation to Union{String, Nothing}, but I felt that sticking with only strings is simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to bring down the TTFX/runtime. On ZMQ.jl this brings the time for
Aqua.test_all(ZMQ)down from ~8.7s to ~6.1s, so about 30%. The downside is that the precompilation time increased from ~1.4s to ~11s, which is quite a hit. My feeling is that it's still worth it though since Aqua has relatively few dependencies and is unlikely to get invalidated frequently. I'd recommend reviewing each commit separately.