Skip to content

Changes recommended Aqua badge link - #354

Merged
fingolfin merged 7 commits into
JuliaTesting:masterfrom
lmiq:fix_badge_link
Feb 24, 2026
Merged

fingolfin merged 7 commits into
JuliaTesting:masterfrom
lmiq:fix_badge_link

Conversation

@lmiq

@lmiq lmiq commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

This PR aims to fix the issue with the badge link that is currently provided. Fixes #353

Apparently github changed the policy regarding access to raw files, thus it is better to link an image from the documentation. Here I add the badge info to the documentation and the badge as an asset of of the docs, which then provides a link that currently works.

@codecov

codecov Bot commented Oct 29, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (c0d6f42) to head (355548c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          11       11           
  Lines         514      514           
=======================================
  Hits          446      446           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread README.md Resolved
@lmiq

lmiq commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

I think this is a good strategy: the link refers to the dev docs badge. Since the badge is referenced in the docs, if for some reason the file is removed or is not accessible, the docs won't build, and thus we guarantee that the badge is always accessible.

@fingolfin

Copy link
Copy Markdown
Member

But if we remove the badge.svg at the top level, that will break the existing badges for many projects, won't it? So I think it should stay in here. (Perhaps replacing it with a symlink would also work, dunno...)

@lmiq

lmiq commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

Yes, you're right. Probably better to keep it there for now. With the updated instructions maybe some day the file can be removed.

@fingolfin fingolfin changed the title fix badge link Changes recommended Aqua badge link Feb 24, 2026
@fingolfin
fingolfin merged commit 2c775ea into JuliaTesting:master Feb 24, 2026
21 checks passed
lgoettgens pushed a commit that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aqua badge not showing up

2 participants