leaving/entering airgap overwrites network.json

[lexx42xxel]

It seems my network.json gets overwritten when entering/leaving airgap mode, losing all my config. Pls retain the file content (you can change enabled to disabled and back but the rest should stay untouched).

[GordonBeeming]

Thanks for reporting this, you were right on both counts. It turned out to be two separate bugs, and the second one was worse than the first.

The toggle rewrote the whole file. --enable-airlock and --disable-airlock read network.json into a typed model, flipped one boolean, and serialized the result back over the top. Anything the model didn't know about was gone: comments, key order, indentation, and any key the class doesn't declare. A file containing JSON comments didn't survive at all, it threw an unhandled exception. This came in with c0c1a83, which replaced a surgical true/false swap with a typed round-trip.

Disabling could empty your ruleset entirely. If your rules lived only in ~/.config/copilot_here/network.json and you ran --disable-airlock inside a project, it created .copilot_here/network.json with allowed_rules: []. A local config replaces the global one outright rather than merging, so re-enabling left that project running with no rules at all, and nothing in the output said so. Your global file was untouched on disk, it was just being ignored from then on. That is most likely the "losing all my config" you saw.

Both are fixed in #133.

Toggling now changes only the enabled value and copies every other byte through untouched, so comments, key order, formatting and unrecognised keys all survive exactly as you wrote them. Creating a local config seeds it from your global one instead of starting empty, and the command tells you when it does. Bad JSON now names the file and exits cleanly rather than throwing a stack trace, and the reader accepts comments and trailing commas, since this is a file people edit by hand.

Review on that PR turned up four more edge cases in the first attempt, all of which are also fixed and covered: duplicate root enabled keys, comments inside an otherwise empty object, single-line files being reformatted, and an error message that claimed a file was invalid JSON when the syntax was fine.

Three related problems came out of the investigation but are not part of this fix, so they are tracked separately: #135, #136 and #137.

Once #133 merges, please re-test with your own network.json and reopen if anything still gets rewritten.