Repository navigation
|
I was able to open any file on Windows in 0.27.6, such as hello_🌎.jpg and in 0.28.0 all of these methods are gone now. For example, this one in #ifdef EXV_UNICODE_PATH
Image::AutoPtr ImageFactory::open(const std::wstring& wpath, bool useCurl)
{
Image::AutoPtr image = open(ImageFactory::createIo(wpath, useCurl)); // may throw
if (image.get() == 0) throw WError(kerFileContainsUnknownImageType, wpath);
return image;
}
#endifOn Windows passing UTF-8 into CRT won't work - Windows expects Anybody knows what happened to these methods and if there's a way to get them back in 0.28.0? |
Answered by
gh-andre
Oct 19, 2023
Replies: 1 comment
|
Turn out @piponazo removed this working code with a comment "Remove dead code around EXV_UNICODE_PATH" and no other reasoning, rendering the library unusable for Windows paths with characters outside Win-1252. This was done in commit 7933ff4. A puzzling change, really. |
0 replies
Answer selected by
gh-andre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Turn out @piponazo removed this working code with a comment "Remove dead code around EXV_UNICODE_PATH" and no other reasoning, rendering the library unusable for Windows paths with characters outside Win-1252. This was done in commit 7933ff4. A puzzling change, really.