Skip to content

PUBLISHER_NAME/APP_COPYRIGHT defaults to Ascensio branding in shipped build output #72

Description

@moodyjmz

Problem

Makefile defaults PUBLISHER_NAME ?= Ascensio System SIA (line 16) and derives APP_COPYRIGHT ?= Copyright (C) $(PUBLISHER_NAME) 2012-$(shell date +%Y). All rights reserved from it (line 18), then passes both into GRUNT_ENV. No override was found anywhere in the actual build pipeline in the sibling repos either (web-apps's docker-bake.hcl/Dockerfile, top-level orchestration Makefiles).

Net effect: unless something outside this repo sets these env vars at build time, shipped build output (bundle banners, any UI surface consuming these) defaults to Ascensio branding.

Why this is separate from the web-apps header-comment fix

Euro-Office/web-apps#186 (fixed in web-apps#191) was a header-comment fix — swapping misattributed copyright comments in files with zero ONLYOFFICE authorship. This is a different, higher-risk problem: it's a runtime default that ships to users, and it spans repos.

Target state — already exists here, partially

Euro-Office/sdkjs#65 (this repo's own webpack migration, unmerged as of writing) already gets this right in its new webpack build path: defaults COMPANY_NAME to 'Euro-Office' and PUBLISHER_URL to https://github.com/Euro-Office/ (build/lib/env.cjs). This issue is about the Makefile/Grunt-env path, which still defaults to Ascensio and needs to match #65's values once merged, rather than drift into a separate convention.

Scope note

Euro-Office/web-apps (build/theme.config.mjs) and Euro-Office/server (Makefile) have the identical default. Matching issues are being filed there (web-apps#192). Needs an actual build to verify before merging, not just a code read — and none of the three should merge independently while the same default is still live elsewhere.

Related: Euro-Office/web-apps#192, Euro-Office/server (companion issue, to be linked).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions