Skip to content

[Enhancement]: Convert the log_file_checks to support pytest.fail reports #170

Description

@bieryAtFnal

Description

As part of reviewing DUNE-DAQ/daqsystemtest#335, Michal mentioned that the 'failure end block' did not give much information about what the problem was when the integtest failed.

This ties in with Eric's suggestion that we convert our assert calls in integtests when problems occur to pytest.fail calls which can provide more useful information than just a boolean (DUNE-DAQ/daqsystemtest#298).

This Issue requests that we use the 3ru_3df_multirun_test to develop this functionality in the log_file_checks that are included in the integrationtest infrastructure. The goal would be to provide some useful information in the 'failure end block' about what the problem was.

Potential impact radius

Medium

Reason for change

The goal of the change would be to make integtest failures more easy to recognize and understand.

Suggested implementations

See DUNE-DAQ/daqsystemtest#298.

Testing suggestions

No response

Anything else?

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions