Skip to content

BUG: ReadOnlyError imported from multiple places #79

Description

@tangkong

The actions framework introduced a ReadOnlyError, and first included it in lume-impact.

When this is upstreamed to lume-base, the error was copied there, and the actions code referenced that exception. This means that notebooks that reference the impact ReadOnlyError will fail (it's a different exception, even though it shares the same name)

In particular: https://github.com/ChristopherMayes/lume-impact/blob/master/docs/examples/lume_model_tutorial.ipynb

This will break things once lume-base gets tagged with the actions code (>0.4.4)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions