From 34398a095f55b3e8f08c508b9a7600d9e23a472b Mon Sep 17 00:00:00 2001 From: marduk Date: Fri, 13 Jun 2025 11:30:16 -0300 Subject: [PATCH 1/3] fix: Regression fix Radio button tests failing (m2-8992) --- .../ui/Items/SelectBase/SelectBaseText.tsx | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx index 513c28984..d6dab6669 100644 --- a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx +++ b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx @@ -8,6 +8,7 @@ type Props = { export const SelectBaseText = (props: Props) => { const { processedWords } = useCustomWordWrap(props.text); + const hasLongWord = processedWords.some(({ needsWrap }) => needsWrap); return ( { cursor: 'pointer', lineBreak: 'normal', display: '-webkit-box', - - // Using kebab-case (i.e. `-webkit-some-things`) would cause warnings - // in the JS console about kebab-case being not supported for CSS - // properties. webkitLineClamp: '3', webkitBoxOrient: 'vertical', }} > - {processedWords.map(({ word, needsWrap, ref }, index) => { - return needsWrap ? ( - - {`${word} `} - - ) : ( - `${word} ` - ); - })} + {hasLongWord + ? processedWords.map(({ word, needsWrap, ref }, index) => + needsWrap ? ( + + {`${word} `} + + ) : ( + `${word} ` + ) + ) + : props.text} ); }; From 879ef154de474db908a0f9278804c8d3da4812c5 Mon Sep 17 00:00:00 2001 From: marduk Date: Fri, 13 Jun 2025 20:15:11 -0300 Subject: [PATCH 2/3] Fix --- src/shared/ui/Items/SelectBase/SelectBaseText.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx index d6dab6669..245addf4d 100644 --- a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx +++ b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx @@ -35,7 +35,7 @@ export const SelectBaseText = (props: Props) => { ) : ( `${word} ` - ) + ), ) : props.text} From 075155c5943e1c403f7661d05348a14128f12396 Mon Sep 17 00:00:00 2001 From: sricharan-varanasi Date: Mon, 4 Aug 2025 09:03:59 -0400 Subject: [PATCH 3/3] Added back comment for kebab-case --- src/shared/ui/Items/SelectBase/SelectBaseText.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx index 245addf4d..e60647a72 100644 --- a/src/shared/ui/Items/SelectBase/SelectBaseText.tsx +++ b/src/shared/ui/Items/SelectBase/SelectBaseText.tsx @@ -23,6 +23,10 @@ export const SelectBaseText = (props: Props) => { cursor: 'pointer', lineBreak: 'normal', display: '-webkit-box', + + // Using kebab-case (i.e. `-webkit-some-things`) would cause warnings + // in the JS console about kebab-case being not supported for CSS + // properties. webkitLineClamp: '3', webkitBoxOrient: 'vertical', }}