fix(ci): stop the coverage step hiding test failures

GitHub's default Linux shell is 'bash -e {0}', which has no pipefail. So
'npm run test:coverage | tee coverage.txt' returned tee's exit code, and a
failing suite reported success. A green job had 1 of 157 tests failing in
it - 'port collision retries +1', a test asserting the auto-relocate
behaviour that was intentionally removed a commit earlier.

'shell: bash' is 'bash -eo pipefail', so the pipeline now propagates the
test result. This has been latent since the tee was introduced.

Also fixed the stale test itself to assert the new contract (fail loudly by
default, relocate only on opt-in), and wrapped it in try/finally: a thrown
assert left the squatter's server handle open, which timed out the whole
file and buried the real failure under an unrelated one.

The CLI suite needed more than the 20s per-test budget, so it now has 60s.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Ahad690

.github/workflows/gateway.yml

@@ -34,11 +34,17 @@ jobs:
 
       - name: Run test suite with coverage
         working-directory: gateway
+        # shell: bash, not the default. The default Linux shell is `bash -e {0}`,
+        # which has NO pipefail - so `... | tee coverage.txt` returns tee's exit
+        # code and a failing suite still reports success. That happened: a green
+        # job with 1 of 157 tests failing. `shell: bash` is `bash -eo pipefail`.
+        shell: bash
         run: npm run test:coverage 2>&1 | tee coverage.txt
 
       - name: Enforce coverage floor
         working-directory: gateway
-        # line 85 / branch 80 / funcs 80. Current: 92.70 / 84.53 / 88.64.
+        # line 85 / branch 80 / funcs 80. Current: 94.24 / 83.51 / 90.73.
+        shell: bash
         run: node scripts/check-coverage.cjs coverage.txt 85 80 80
 
       - name: Upload coverage report

gateway/bin/proxima-gw.js

@@ -174,7 +174,7 @@ function table(rows, headers) {
 
 async function cmdCheck() {
     const { port, via } = resolvePort();
-    const res = await call('ping', null, {}, 4000);
+    const res = await call('ping', null, {}, 2500);
     if (res.ok) {
         say(`gateway  RUNNING  on 127.0.0.1:${port}  (port from ${via})`);
         return EXIT.OK;
@@ -188,7 +188,7 @@ async function cmdCheck() {
 }
 
 async function cmdStatus() {
-    const health = await call('ping', null, {}, 4000);
+    const health = await call('ping', null, {}, 2500);
     if (!health.ok) {
         fail(`Gateway not reachable: ${health.error}`);
         fail('Start it with: node src\\index.js');

gateway/package.json

@@ -7,8 +7,8 @@
   "main": "src/index.js",
   "scripts": {
     "start": "node src/index.js",
-    "test": "node --test --test-reporter=tap --test-timeout=20000 test/unit.test.js test/integration.test.js test/contract.test.js test/redact.test.js test/leak.test.js test/engines.test.js test/regression.test.js test/cli.test.js",
-    "test:coverage": "node --test --test-reporter=tap --experimental-test-coverage --test-timeout=20000 test/unit.test.js test/integration.test.js test/contract.test.js test/redact.test.js test/leak.test.js test/engines.test.js test/regression.test.js test/cli.test.js",
+    "test": "node --test --test-reporter=tap --test-timeout=60000 test/unit.test.js test/integration.test.js test/contract.test.js test/redact.test.js test/leak.test.js test/engines.test.js test/regression.test.js test/cli.test.js",
+    "test:coverage": "node --test --test-reporter=tap --experimental-test-coverage --test-timeout=60000 test/unit.test.js test/integration.test.js test/contract.test.js test/redact.test.js test/leak.test.js test/engines.test.js test/regression.test.js test/cli.test.js",
     "test:browser": "node --test --test-reporter=tap --test-timeout=60000 test/browser.test.js",
     "test:all": "npm run test:coverage && npm run test:browser",
     "coverage:check": "node scripts/check-coverage.cjs",

gateway/test/unit.test.js

@@ -233,18 +233,31 @@ test('server refuses a non-loopback bind (P7)', () => {
     );
 });
 
-test('port collision retries +1 then reports both ports (F2)', async () => {
+test('a port collision fails loudly rather than relocating (F2)', async () => {
     const s = new StateStore(tmpDir());
     const squatter = new IpcServer({ handler: async () => ({ success: true }), stateStore: s, port: 0 });
-    const taken = await squatter._tryListen(0);
-    const takenPort = squatter.server.address().port;
-
-    const second = new IpcServer({ handler: async () => ({ success: true }), stateStore: s, port: takenPort });
-    const bound = await second.listen();
-    assert.equal(bound, takenPort + 1, 'must land on the next port');
-
-    await second.close();
-    await squatter.close();
+    const second = new IpcServer({ handler: async () => ({ success: true }), stateStore: s, port: 0 });
+
+    try {
+        await squatter._tryListen(0);
+        const takenPort = squatter.server.address().port;
+        const colliding = new IpcServer({ handler: async () => ({ success: true }), stateStore: s, port: takenPort });
+
+        // Relocation is opt-in. Silently moving to port+1 would leave a fact pointing
+        // a client at whichever process won the real port.
+        await assert.rejects(() => colliding.listen(), /already in use/);
+
+        // Opting in relocates, and is explicit about it.
+        const moved = await colliding.listen({ allowRelocate: true });
+        assert.equal(moved, takenPort + 1);
+
+        await colliding.close();
+    } finally {
+        // Without this the squatter's handle stays open and the whole test FILE times
+        // out, which masks the real failure behind an unrelated one.
+        await second.close();
+        await squatter.close();
+    }
 });
 
 // ---------------------------------------------------------------- engines